Cleanup old LS remainders, disable CLI tests for now, rm ephemeral tests#813
Merged
Cleanup old LS remainders, disable CLI tests for now, rm ephemeral tests#813
Conversation
machty
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from previous PR to shift much of the testing logic from deprecated Volar language server to TS Plugin, this PR removes the last remnants of testing code that uses ephemeral/throwaway directories for the purpose of testing various configurations of Glint projects. This approach worked well but ultimately makes a migration towards pnpm very difficult. I've chosen to pend CLI tests so that they can be later rebuilt on a case-by-case basis (we can lean on Volar more to test toolkit functionality than "testing the framework" with our own suite).
I also removed the "scripts" package which had things like glint auto-nocheck. If there is large demand for this we can consider reinstating but I figure most people who will use new Glint already have old Glint and have run these scripts.